Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub link on control.ros.org #1022

Merged
merged 3 commits into from
May 16, 2023

Conversation

christophfroehlich
Copy link
Contributor

I forgot to add the link in one file with #1019
Please also backport to humble

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #1022 (fc1b43a) into master (925f5f3) will decrease coverage by 1.92%.
The diff coverage is 35.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   34.61%   32.70%   -1.92%     
==========================================
  Files          52       91      +39     
  Lines        2981     9553    +6572     
  Branches     1855     6433    +4578     
==========================================
+ Hits         1032     3124    +2092     
- Misses        310      704     +394     
- Partials     1639     5725    +4086     
Flag Coverage Δ
unittests 32.70% <35.62%> (-1.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.27% <ø> (-1.44%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

@bmagyar bmagyar merged commit 0eb319e into ros-controls:master May 16, 2023
1 check passed
@bmagyar
Copy link
Member

bmagyar commented May 16, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2023
bmagyar pushed a commit that referenced this pull request May 16, 2023
(cherry picked from commit 0eb319e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich deleted the fix_github_links branch May 16, 2023 11:33
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
…1024)

(cherry picked from commit 0eb319e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants