Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MockHardware] Enable disabling of command to simulate HW failures. #1027

Merged
merged 4 commits into from
Jun 4, 2023
Merged

[MockHardware] Enable disabling of command to simulate HW failures. #1027

merged 4 commits into from
Jun 4, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented May 17, 2023

@destogl destogl self-assigned this May 17, 2023
@destogl destogl requested a review from livanov93 May 17, 2023 00:38
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #1027 (3fb8202) into master (925f5f3) will decrease coverage by 2.01%.
The diff coverage is 35.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   34.61%   32.61%   -2.01%     
==========================================
  Files          52       91      +39     
  Lines        2981     9591    +6610     
  Branches     1855     6467    +4612     
==========================================
+ Hits         1032     3128    +2096     
- Misses        310      706     +396     
- Partials     1639     5757    +4118
Flag Coverage Δ
unittests 32.61% <35.66%> (-2.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.07% <ø> (-1.64%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.04% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

christophfroehlich
christophfroehlich requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add this option to the docs

bmagyar
bmagyar previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but agree w @christophfroehlich

livanov93
livanov93 previously approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@destogl
Copy link
Member Author

destogl commented May 26, 2023

OK, will add docs and then merge.

@destogl destogl dismissed stale reviews from livanov93 and bmagyar via 3914a2c May 31, 2023 18:40
@destogl
Copy link
Member Author

destogl commented May 31, 2023

Please check the updated docs.

@bmagyar @christophfroehlich
Small docs touchups
2dce100 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@bmagyar bmagyar merged commit bc8052a into master Jun 4, 2023
1 check passed
@destogl destogl deleted the disabling-commands-mock-hw branch June 5, 2023 13:15
@destogl destogl added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 5, 2023
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@destogl @mergify
[MockHardware] Enable disabling of command to simulate HW failures. (#…
0c61746 
…1027)

(cherry picked from commit bc8052a)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst
@mergify mergify bot mentioned this pull request Jun 5, 2023
Merged
destogl added a commit that referenced this pull request Jun 5, 2023
@destogl
Fix trailing space introduces in #1027
d91e354
destogl added a commit that referenced this pull request Jun 7, 2023
@destogl
[MockHardware] Enable disabling of command to simulate HW failures. (#…
b5e6865 
…1027)

(cherry picked from commit bc8052a)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst
destogl added a commit that referenced this pull request Jun 8, 2023
@mergify @destogl
[MockHardware] Enable disabling of command to simulate HW failures. (…
a8aa03a 
…backport #1027) (#1050)

* [MockHardware] Enable disabling of command to simulate HW failures. (#1027)

(cherry picked from commit bc8052a)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst

---------

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
destogl added a commit to StoglRobotics-forks/ros2_control that referenced this pull request Jun 14, 2023
@destogl
Fix trailing space introduces in ros-controls#1027
471f2df
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
@mergify @destogl @flochre
[MockHardware] Enable disabling of command to simulate HW failures. (…
f9f487c 
…backport ros-controls#1027) (ros-controls#1050)

* [MockHardware] Enable disabling of command to simulate HW failures. (ros-controls#1027)

(cherry picked from commit bc8052a)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst

---------

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich requested changes

@bmagyar bmagyar bmagyar approved these changes

@duringhof duringhof Awaiting requested review from duringhof

@erickisos erickisos Awaiting requested review from erickisos

@jackcenter jackcenter Awaiting requested review from jackcenter

@jaron-l jaron-l Awaiting requested review from jaron-l

@rosterloh rosterloh Awaiting requested review from rosterloh

@livanov93 livanov93 Awaiting requested review from livanov93

Assignees

@destogl destogl

Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@destogl @codecov-commenter @christophfroehlich @bmagyar @livanov93