Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflows, badges and repos file for ROS Iron #1034

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 26, 2023

Since ros2_control is also released for iron, it would make sense to add workflows for iron. Now that industrial-ci is available for iron, as well, there should be nothing blocking this anymore.

This PR assumes there will be an iron branch (which would probably be pointing towards master atm). If this is not desired and iron should be built from master, the PR will have to be adapted.

@bmagyar
Copy link
Member

bmagyar commented May 26, 2023

Thanks a lot and indeed for the next few weeks we probably won't branch for Iron.

@fmauch
Copy link
Contributor Author

fmauch commented May 26, 2023

Alright, then I'll update this accordingly.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #1034 (82596d7) into master (925f5f3) will decrease coverage by 2.17%.
The diff coverage is 35.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   34.61%   32.45%   -2.17%     
==========================================
  Files          52       92      +40     
  Lines        2981     9681    +6700     
  Branches     1855     6511    +4656     
==========================================
+ Hits         1032     3142    +2110     
- Misses        310      772     +462     
- Partials     1639     5767    +4128     
Flag Coverage Δ
unittests 32.45% <35.16%> (-2.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.23% <ø> (-1.48%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.16% <ø> (-6.47%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.53% <ø> (ø)
... and 70 more

... and 18 files with indirect coverage changes

@fmauch
Copy link
Contributor Author

fmauch commented May 26, 2023

@bmagyar updated the PR to not expect an iron branch.

@fmauch
Copy link
Contributor Author

fmauch commented May 26, 2023

Updated author information, as I had setup my container wrong.

@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

This pull request is in conflict. Could you fix it @fmauch?

Since ros2_control is also released for iron, it would make sense to add workflows for iron.
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

This pull request is in conflict. Could you fix it @fmauch?

@bmagyar bmagyar merged commit e89fbe7 into ros-controls:master Jun 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants