Add checks if hardware is initialized. #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is in conflict. Could you fix it @destogl? |
destogl
force-pushed
the
add-checks-if-hw-initialized
branch
from
ad30d48
to
9e630a6
Compare
|
Worth adding a test? |
|
Actually, yes, but no motivation... Have to find it first :D |
VX792
approved these changes
Jun 22, 2023
bmagyar
reviewed
Jun 23, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 34.61% 32.26% -2.36%
==========================================
Files 52 94 +42
Lines 2981 9915 +6934
Branches 1855 6694 +4839
==========================================
+ Hits 1032 3199 +2167
- Misses 310 787 +477
- Partials 1639 5929 +4290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
destogl
force-pushed
the
add-checks-if-hw-initialized
branch
from
5b61160
to
a6f73c8
Compare
bmagyar
added
the
backport-humble
bmagyar
approved these changes
Jul 18, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit 6cd8191) # Conflicts: # hardware_interface/src/resource_manager.cpp
bmagyar
pushed a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes potential bugs where interfaces are added but hardware is not initialized.