Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller sorting and proper execution in a chain (Fixes #853) #1063

Merged
merged 25 commits into from
Aug 11, 2023
Merged

Controller sorting and proper execution in a chain (Fixes #853) #1063

merged 25 commits into from
Aug 11, 2023

Commits on Jul 7, 2023

  1. Added test for the reordering controllers case

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bd17cc7 View commit details
    Browse the repository at this point in the history

  2. Perform controller sorting at the end of switch_controller

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a8a311b View commit details
    Browse the repository at this point in the history

  3. fix the list_chained_controllers_srv test case for the new controller… 

    … sorting
    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    61ed14b View commit details
    Browse the repository at this point in the history

  4. move the logic to a separate function

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    705f70f View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
    @saikishor @christophfroehlich
    saikishor and christophfroehlich committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e03865c View commit details
    Browse the repository at this point in the history

  6. remove obsolete TODO comments in the controller chaining tests

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    abfaf8a View commit details
    Browse the repository at this point in the history

  7. Add a test case to sort 6 controllers in chained mode

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d7e5a1c View commit details
    Browse the repository at this point in the history

  8. Added a method to retrieve the following controller names given a con… 

    …troller name
    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1d701d6 View commit details
    Browse the repository at this point in the history

  9. Update the controller_sorting method to support progressive chaining … 

    …ability
    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1a66476 View commit details
    Browse the repository at this point in the history

  10. Added test case to sort chained controllers with branching

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    5ec08af View commit details
    Browse the repository at this point in the history

  11. Added a method to retrieve the preceding controller names given a con… 

    …troller name
    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2f7b9c6 View commit details
    Browse the repository at this point in the history

  12. Added logic to controller_sorting to support sorting branched control… 

    …ler chains
    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4a5cafa View commit details
    Browse the repository at this point in the history

  13. Added some documentation to the newly added functions

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    fc8a876 View commit details
    Browse the repository at this point in the history

  14. Add debug print of reordered controllers list once they are sorted

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8a9b5d2 View commit details
    Browse the repository at this point in the history

  15. Add the condition to skip the non-configured controllers

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9253c86 View commit details
    Browse the repository at this point in the history

  16. remove logging for every command interface

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    136d2b7 View commit details
    Browse the repository at this point in the history

  17. Improve the complex chain test case checking

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    41686d3 View commit details
    Browse the repository at this point in the history

  18. added a test case to sort independent chains

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d19a100 View commit details
    Browse the repository at this point in the history

  19. Added fixes for the independent chains sorting

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    685701d View commit details
    Browse the repository at this point in the history

  20. better randomization in independent chains testing

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ea103d8 View commit details
    Browse the repository at this point in the history

  21. Fix minor logic issues

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9d33f4a View commit details
    Browse the repository at this point in the history

  22. Add 3rd chain for better complex testing

    @saikishor
    saikishor committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3ef00f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Apply suggestions from code review - Denis 

    Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
    @saikishor @destogl
    saikishor and destogl authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    cbc4322 View commit details
    Browse the repository at this point in the history

  2. address pull request review comments

    @saikishor
    saikishor committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1d5fc43 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'master' into controller_sorting

    @bmagyar
    bmagyar authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1dc67ae View commit details
    Browse the repository at this point in the history