-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting of initial state in HW compoments (backport #1046) #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cf4448d) # Conflicts: # controller_manager/src/controller_manager.cpp # hardware_interface/include/hardware_interface/resource_manager.hpp # hardware_interface/src/resource_manager.cpp
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
livanov93,
mcbed and
mhubii
June 23, 2023 18:24
@destogl should we fix this or no backport? |
We should fix this, but first merge #1052 |
erickisos
reviewed
Aug 3, 2023
erickisos
approved these changes
Aug 3, 2023
needs #1216 first |
This pull request is in conflict. Could you fix it @mergify[bot]? |
destogl
reviewed
Jan 12, 2024
hardware_interface/include/hardware_interface/resource_manager.hpp
Outdated
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/resource_manager.hpp
Outdated
Show resolved
Hide resolved
destogl
reviewed
Jan 12, 2024
destogl
reviewed
Jan 12, 2024
destogl
reviewed
Jan 12, 2024
github-actions
bot
requested review from
aprotyas,
DasRoteSkelett,
destogl,
duringhof and
jaron-l
January 12, 2024 17:58
@destogl I fixed this PR. ABI check fails, but this is only because of the test files? Shouldn't break anything from users? |
christophfroehlich
approved these changes
Jan 15, 2024
skpawar1305
added a commit
to cyberbotics/webots_ros2
that referenced
this pull request
Feb 20, 2024
skpawar1305
added a commit
to cyberbotics/webots_ros2
that referenced
this pull request
Feb 20, 2024
omichel
pushed a commit
to cyberbotics/webots_ros2
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1046 done by Mergify.
Cherry-pick of cf4448d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com