Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using SCHED_FIFO on any kernel #1142

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 23, 2023

A while back, we did some deeper investigation of cycle-time effects of different kernel / scheduling setups (https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/60f08359f6484d1671e12bab6e01fc49eb0fadc8/ur_robot_driver/doc/real_time_benchmarking.md).

Based on this, using SCHED_FIFO is beneficial on any system, not only real-time kernels. Thus, I suggest alwats trying FIFO scheduling in the CM.

I've swapped the user setup before the kernel setup in the userdocs for two reasons:

  • Since the CM now will put a warning about FIFO scheduling in every run, the method of avoiding this warning should be put first
  • Users might be repelled from installing another kernel, especially installing an RT-kernel. (At least that's our experience from issue reports). This should not necessarily stop them from setting up their ROS user to use SCHED_FIFO.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1142 (f3f0b11) into master (bd6911d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f3f0b11 differs from pull request most recent head ff6be5a. Consider uploading reports for the commit ff6be5a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   31.62%   31.63%           
=======================================
  Files          94       94           
  Lines       10838    10836    -2     
  Branches     7419     7419           
=======================================
  Hits         3428     3428           
+ Misses        804      802    -2     
  Partials     6606     6606           
Flag Coverage Δ
unittests 31.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)

Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉❣️

@bmagyar bmagyar merged commit 0a3705f into ros-controls:master Dec 20, 2023
16 of 17 checks passed
@fmauch fmauch deleted the cm_sched_on_any_system branch December 20, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants