-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MockHardware] Fix the issues where hardware with multiple interfaces can not be started because of a logical bug added when adding dynamics calculation functionality. #1151
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
===========================================
- Coverage 47.57% 31.46% -16.12%
===========================================
Files 41 94 +53
Lines 3449 10937 +7488
Branches 1873 7507 +5634
===========================================
+ Hits 1641 3441 +1800
- Misses 482 805 +323
- Partials 1326 6691 +5365
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…rted because of a logical bug added when adding dynamics calculation functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this code to test ratio
…terfaces can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151)" This reverts commit 8bf1a8a.
@destogl Could you please backport this to humble branch? The mentioned issue affect the latest Humble ros2_control binary release |
… can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151) Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
…terfaces can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151)" This reverts commit 8bf1a8a.
Fixes #1144.
I have introduces this bug. The issues is that if one is not using dynamic calculations there is no limitation on interfaces used.
I have also added a test to avoid this hapening again.