Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHEL-CI] Rename workflow and don't run on push #1326

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

christophfroehlich
Copy link
Contributor

Applying changes suggested here #1310 (comment) and add verbose option to colcon test-result

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Jan 22, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51ff9ce) 48.02% compared to head (fd816ea) 48.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files          41       41           
  Lines        3525     3525           
  Branches     1912     1912           
=======================================
  Hits         1693     1693           
  Misses        442      442           
  Partials     1390     1390           
Flag Coverage Δ
unittests 48.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. +1 for naming and breaking up the different steps.

@bmagyar bmagyar merged commit fd2cc4e into ros-controls:master Jan 23, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
(cherry picked from commit fd2cc4e)

# Conflicts:
#	.github/workflows/humble-rhel-binary-build.yml
#	.github/workflows/iron-rhel-binary-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
destogl pushed a commit that referenced this pull request Jan 23, 2024
(cherry picked from commit fd2cc4e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich deleted the ci_rhel branch January 23, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants