Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Fix controller parameter loading issue in different cases (backport #1293) #1332

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

saikishor
Copy link
Member

Backport of the PR: #1293

Copy link
Contributor

mergify bot commented Jan 23, 2024

@saikishor, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (a8e21fc) 31.17% compared to head (c397e24) 31.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1332      +/-   ##
==========================================
- Coverage   31.17%   31.14%   -0.04%     
==========================================
  Files          95       95              
  Lines       10706    10731      +25     
  Branches     7401     7421      +20     
==========================================
+ Hits         3338     3342       +4     
- Misses        706      715       +9     
- Partials     6662     6674      +12     
Flag Coverage Δ
unittests 31.14% <13.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../include/controller_manager/controller_manager.hpp 66.66% <ø> (ø)
controller_manager/src/controller_manager.cpp 36.88% <13.33%> (-0.47%) ⬇️

@Noel215
Copy link
Contributor

Noel215 commented Jan 24, 2024

Tested on simulation with ros-controls/ros2_controllers#978, as in the original PR. It is working for me.

@destogl destogl merged commit fe5b4f1 into ros-controls:humble Jan 25, 2024
12 of 14 checks passed
@saikishor saikishor deleted the bp/humble/pr-1293 branch August 17, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants