Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about initial_value regarding mock_hw #1352

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jan 31, 2024

This should fix #1351. I added documentation on the mock_hardware page and on the components overview page in the example URDF.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25aa5d3) 47.53% compared to head (0d321b8) 47.53%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1352   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3547     3547           
  Branches     1930     1930           
=======================================
  Hits         1686     1686           
  Misses        459      459           
  Partials     1402     1402           
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hardware_interface/doc/mock_components_userdoc.rst Outdated Show resolved Hide resolved
@destogl destogl merged commit 26815e8 into ros-controls:master Feb 1, 2024
15 of 16 checks passed
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@fmauch fmauch deleted the document_initial_value branch February 2, 2024 09:40
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 29, 2024
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
christophfroehlich pushed a commit that referenced this pull request Apr 29, 2024
christophfroehlich pushed a commit that referenced this pull request Apr 29, 2024
christophfroehlich pushed a commit that referenced this pull request Apr 29, 2024
…#1514)

(cherry picked from commit 26815e8)

Co-authored-by: Felix Exner (fexner) <exner@fzi.de>
christophfroehlich pushed a commit that referenced this pull request Apr 29, 2024
…#1513)

(cherry picked from commit 26815e8)

Co-authored-by: Felix Exner (fexner) <exner@fzi.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for mock system's initial_value parameter is missing
4 participants