Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized debug output in CM about interfaces when switching controllers. #1355

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Optimized debug output in CM about interfaces when switching controllers. #1355

merged 3 commits into from
Feb 1, 2024

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 1, 2024 •
edited
Loading

A part of #1237

bmagyar
bmagyar previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

saikishor
saikishor approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

controller_manager/src/controller_manager.cpp Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5b5f332) 47.53% compared to head (08986c7) 47.49%.
Report is 2 commits behind head on master.

❗ Current head 08986c7 differs from pull request most recent head 97786cd. Consider uploading reports for the commit 97786cd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
- Coverage   47.53%   47.49%   -0.04%     
==========================================
  Files          41       41              
  Lines        3549     3556       +7     
  Branches     1931     1938       +7     
==========================================
+ Hits         1687     1689       +2     
  Misses        459      459              
- Partials     1403     1408       +5
Flag Coverage Δ
unittests 47.49% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.76% <20.00%> (-0.06%) ⬇️

@destogl @saikishor
Update controller_manager/src/controller_manager.cpp
97786cd 
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@destogl destogl merged commit 1104d80 into master Feb 1, 2024
13 of 15 checks passed
@destogl destogl deleted the cm-optimize-debug-output branch February 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar left review comments

@aprotyas aprotyas Awaiting requested review from aprotyas

@fmauch fmauch Awaiting requested review from fmauch

@jaron-l jaron-l Awaiting requested review from jaron-l

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@destogl @bmagyar @saikishor