Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Use explicit constants in controller tests. (backport #1356) #1359

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2024

This is an automatic backport of pull request #1356 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (06f5876) 31.03% compared to head (ebbca88) 31.03%.
Report is 1 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1359   +/-   ##
=======================================
  Coverage   31.03%   31.03%           
=======================================
  Files          95       95           
  Lines       10729    10729           
  Branches     7421     7421           
=======================================
  Hits         3330     3330           
  Misses        723      723           
  Partials     6676     6676           
Flag Coverage Δ
unittests 31.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/test/test_load_controller.cpp 26.43% <0.00%> (ø)

@bmagyar bmagyar merged commit 4409e77 into humble Feb 1, 2024
15 of 16 checks passed
@mergify mergify bot deleted the mergify/bp/humble/pr-1356 branch February 1, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants