Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix ref for scheduled pipelines #1361

Merged

Conversation

christophfroehlich
Copy link
Contributor

  • workflow schedules are (only) run from master branch
  • without giving an explicit ref argument the humble+iron workflows have checked out the master branch, which obviously fails
  • fixed now with this if-clause in the ref field

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b5f332) 47.53% compared to head (9a6e526) 47.53%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1361   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3549     3549           
  Branches     1931     1931           
=======================================
  Hits         1687     1687           
+ Misses        459      458    -1     
- Partials     1403     1404    +1     
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there a reason why the tests are failing on debian and RHEL? Seems unrelated to this PR, though.

@christophfroehlich
Copy link
Contributor Author

Looks good to me. Is there a reason why the tests are failing on debian and RHEL? Seems unrelated to this PR, though.

flaky tests, yeah: #1338 (comment)

@bmagyar bmagyar merged commit a1b0377 into ros-controls:master Feb 5, 2024
16 of 18 checks passed
@christophfroehlich christophfroehlich deleted the ci_humble_iron_schedule branch March 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants