Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improvements and Cleanups #1376

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 7, 2024

Similar to ros-controls/ros2_controllers#1028

RHEL/Debian

  • Build and test only the packages from this repo, instead of all packages imported with the repos file. I used colcon list instead of hardcoding it as it is done with the lint jobs.
  • Split build and test steps, and let the test step continue-on-error: The main goal is to detect compilation problems with unsupported C++ features, which are now visible at first glance. Tests remain flaky on theses platforms, which is a different issue.
  • Activate test of ros2controlcli on debian, it seems to succeed now.

Others

  • Use a single package list for lint job

Backport after #1364 #1374 / #1365 #1375

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (786d5b5) 47.49% compared to head (b8bf81c) 75.97%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1376       +/-   ##
===========================================
+ Coverage   47.49%   75.97%   +28.47%     
===========================================
  Files          41       41               
  Lines        3556     3355      -201     
  Branches     1938     1931        -7     
===========================================
+ Hits         1689     2549      +860     
+ Misses        459      418       -41     
+ Partials     1408      388     -1020     
Flag Coverage Δ
unittests 75.97% <ø> (+28.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

@bmagyar bmagyar merged commit 3252a27 into ros-controls:master Feb 8, 2024
17 checks passed
@christophfroehlich christophfroehlich deleted the ci_cleanup branch February 8, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants