-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for state of the controller node before cleanup (backport #1363) #1378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might fix the conflicts
(cherry picked from commit 6f57faf) # Conflicts: # controller_manager/test/test_controller_manager_srvs.cpp
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
5d03eea
to
ed491ed
Compare
unfortunately no :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to remove this part of the test
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1378 +/- ##
==========================================
- Coverage 75.86% 75.77% -0.10%
==========================================
Files 41 41
Lines 3224 3228 +4
Branches 1838 1839 +1
==========================================
Hits 2446 2446
- Misses 414 415 +1
- Partials 364 367 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automatic backport of pull request #1363 done by Mergify.
Cherry-pick of 6f57faf has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com