Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the controller sorting with an approach similar to directed acyclic graphs #1384

Merged
merged 34 commits into from
Mar 6, 2024
Merged

Change the controller sorting with an approach similar to directed acyclic graphs #1384

merged 34 commits into from
Mar 6, 2024

Commits on Feb 11, 2024

  1. added reference lists of following and preeceding controllers to Cont… 

    …rollerSpec
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    931fc43 View commit details
    Browse the repository at this point in the history

  2. change to a different struct for easiness and ownership

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    72f6ca5 View commit details
    Browse the repository at this point in the history

  3. add a utility method to add elements to the list if they don't exist

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    34b5694 View commit details
    Browse the repository at this point in the history

  4. Add controller_chain_spec and update the following controllers based … 

    …on the command interfaces
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    dd9119c View commit details
    Browse the repository at this point in the history

  5. Add current configured controller to the preceding controller list of… 

    … the controller exposing reference interface
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    6a2ab8b View commit details
    Browse the repository at this point in the history

  6. Apply the same type of logic for state interfaces

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b5a0c74 View commit details
    Browse the repository at this point in the history

  7. Add utility method to remove elements from the list

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1d93659 View commit details
    Browse the repository at this point in the history

  8. Added a method to cleanup the controller chain spec upon node cleanup… 

    … (reconfigure and unloading the controller)
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    95c7026 View commit details
    Browse the repository at this point in the history

  9. added a lambda to find the controllerSpec by controller name

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2ba75ff View commit details
    Browse the repository at this point in the history

  10. added a lambda to check if a ControllerSpec for a given controller name

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    de7f97f View commit details
    Browse the repository at this point in the history

  11. comment out the lambdas

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f728a3a View commit details
    Browse the repository at this point in the history

  12. Added 2 new methods to perform controller sorting

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3042a85 View commit details
    Browse the repository at this point in the history

  13. added lines to start checking out the list

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7ab583d View commit details
    Browse the repository at this point in the history

  14. remove resetting the list on configure as there might be another cont… 

    …roller added as predecessor
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9bb56bb View commit details
    Browse the repository at this point in the history

  15. initialize empty spec for the broadcasters

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    708b42f View commit details
    Browse the repository at this point in the history

  16. add formatting changes

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    0a31887 View commit details
    Browse the repository at this point in the history

  17. remove the unnecessary conditioning in the insert_controller method

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    6a43be7 View commit details
    Browse the repository at this point in the history

  18. fix the typo in the tests documentation

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    aa22855 View commit details
    Browse the repository at this point in the history

  19. change the conditioning to set the default ControllerChainSpec

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    81f43f1 View commit details
    Browse the repository at this point in the history

  20. add propagate option to the method

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    a1134b4 View commit details
    Browse the repository at this point in the history

  21. comment out unnecessary code and only use insert_controller method

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e82b1f9 View commit details
    Browse the repository at this point in the history

  22. comment out old sorting and test the current implementation

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    81ed774 View commit details
    Browse the repository at this point in the history

  23. remove propagate option and check the new controller iterator every i… 

    …teration
    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    eba4f7e View commit details
    Browse the repository at this point in the history

  24. remove commented part of the code

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    d5f60d6 View commit details
    Browse the repository at this point in the history

  25. cleanup the code and remove commented part

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5a4c46f View commit details
    Browse the repository at this point in the history

  26. remove old controller sorting code

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    fa7c972 View commit details
    Browse the repository at this point in the history

  27. rename the method to update_list_with_controller_chain

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4c2f54e View commit details
    Browse the repository at this point in the history

  28. remove unnecessary method

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7218012 View commit details
    Browse the repository at this point in the history

  29. change the logging tot DEBUG

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3cef552 View commit details
    Browse the repository at this point in the history

  30. modify a bit the logging of reordered list

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    0b9584f View commit details
    Browse the repository at this point in the history

  31. fix formatting

    @saikishor
    saikishor committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f23139c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'master' into update/controller_sorting_algorithm

    @saikishor
    saikishor committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5ee4d36 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'master' into update/controller_sorting_algorithm

    @saikishor
    saikishor committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    43846bd View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'master' into update/controller_sorting_algorithm

    @saikishor
    saikishor committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b95c255 View commit details
    Browse the repository at this point in the history