Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reviewer-lottery list to ros2_control_ci #1395

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Move reviewer-lottery list to ros2_control_ci #1395

merged 2 commits into from
Feb 15, 2024

Conversation

christophfroehlich
Copy link
Contributor

A central place for the reviewer database

@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (786d5b5) 47.49% compared to head (8482479) 75.88%.
Report is 11 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1395       +/-   ##
===========================================
+ Coverage   47.49%   75.88%   +28.38%     
===========================================
  Files          41       41               
  Lines        3556     3359      -197     
  Branches     1938     1935        -3     
===========================================
+ Hits         1689     2549      +860     
+ Misses        459      418       -41     
+ Partials     1408      392     -1016
Flag Coverage Δ
unittests 75.88% <20.00%> (+28.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 69.43% <20.00%> (+30.66%) ⬆️

... and 31 files with indirect coverage changes

saikishor
saikishor approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!
It seems to run from the new config.
Thank you @christophfroehlich

@christophfroehlich
Copy link
Contributor Author

Nice!! It seems to run from the new config. Thank you @christophfroehlich

No it doesn't, it uses always the workflow file from the master branch instead of the PR. But I haven't looked into it, because normally this doesn't change often

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 15, 2024
@saikishor
Copy link
Member

No it doesn't, it uses always the workflow file from the master branch instead of the PR. But I haven't looked into it, because normally this doesn't change often

Gotcha

@bmagyar bmagyar merged commit 5f9be40 into ros-controls:master Feb 15, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
@christophfroehlich @mergify
Move reviewer-lottery list to ros2_control_ci (#1395)
eeb75fd 
(cherry picked from commit 5f9be40)

# Conflicts:
#	.github/reviewer-lottery.yml
@mergify mergify bot mentioned this pull request Feb 15, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
@christophfroehlich @mergify
Move reviewer-lottery list to ros2_control_ci (#1395)
1260df2 
(cherry picked from commit 5f9be40)

# Conflicts:
#	.github/reviewer-lottery.yml
@mergify mergify bot mentioned this pull request Feb 15, 2024
Merged
bmagyar pushed a commit that referenced this pull request Feb 16, 2024
@mergify
Move reviewer-lottery list to ros2_control_ci (#1395) (#1399)
1122739
bmagyar pushed a commit that referenced this pull request Feb 16, 2024
@mergify
Move reviewer-lottery list to ros2_control_ci (#1395) (#1398)
69af7dc
@christophfroehlich christophfroehlich mentioned this pull request Feb 17, 2024
Merged
@christophfroehlich christophfroehlich deleted the reviewer_lottery_config branch March 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christophfroehlich @saikishor @olivier-stasse @bmagyar @aprotyas