Fix multiple chainable controller activation bug #1401
Conversation
saikishor
force-pushed
the
fix/multiple/chainable_controller_activation
branch
from
c7c6ca2
to
8cb1154
Compare
|
@christophfroehlich @bmagyar It seems the review lottery is failing after merging #1385, should we do something about it? FYI : https://github.com/ros-controls/ros2_control/actions/runs/7936764298/job/21672717332?pr=1401 |
saikishor
added
backport-humble
damn, thanks for reporting. anyone proficient with typescript for reverse engineering of the reviewer-lottery? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1401 +/- ##
===========================================
+ Coverage 47.49% 75.90% +28.41%
===========================================
Files 41 41
Lines 3556 3362 -194
Branches 1938 1937 -1
===========================================
+ Hits 1689 2552 +863
+ Misses 459 417 -42
+ Partials 1408 393 -1015
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Not me 😞 |
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
|
Hi everyone, I can confirm that this fix solves #1400. The unit tests pass and our code runs normally now on humble. Kindly |
(cherry picked from commit 1cc73c2) # Conflicts: # controller_manager/src/controller_manager.cpp # controller_manager/test/test_controller_manager_srvs.cpp
(cherry picked from commit 1cc73c2) # Conflicts: # controller_manager/src/controller_manager.cpp # controller_manager/test/test_controller_manager_srvs.cpp
Fixes the issue of the failing multiple chainable controller activation by the resource manager. This is happening due to the newly added code in the PR: #1218 under the method
prepare_command_mode_switchmethodFixes #1400
Closes #1369 (I think this should fix the same issue addressed in this PR)