Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Code coverage + pre-commit #1413

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

christophfroehlich
Copy link
Contributor

  • Use coverage workflows from ros2_control_ci
  • Use pre-commit workflow from ros2_control_ci (combines old format and lint job)
  • Fix pre-commit errors

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 23, 2024
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing those smaller quirks on the way :-)

@bmagyar bmagyar merged commit 1538c91 into ros-controls:master Feb 25, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
(cherry picked from commit 1538c91)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-format.yml
#	.github/workflows/ci-ros-lint.yml
#	.pre-commit-config.yaml
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
(cherry picked from commit 1538c91)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-ros-lint.yml
#	.pre-commit-config.yaml
destogl added a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
@christophfroehlich christophfroehlich deleted the ci_coverage_precommit branch March 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants