Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conditioning to have rolling tags compilable in older versions #1422

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Feb 29, 2024

As discussed in the yesterday's WG meeting, I've added some small fixes that will enable us to compile rolling tags directly in earlier versions from now on.

The following are the breaking changes between both versions:

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (0711cd6) to head (24b9f05).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1422       +/-   ##
===========================================
+ Coverage   47.59%   75.89%   +28.30%     
===========================================
  Files          41       41               
  Lines        3553     3352      -201     
  Branches     1932     1926        -6     
===========================================
+ Hits         1691     2544      +853     
+ Misses        459      415       -44     
+ Partials     1403      393     -1010     
Flag Coverage Δ
unittests 75.89% <100.00%> (+28.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...controller_interface/controller_interface_base.hpp 90.00% <100.00%> (+52.50%) ⬆️
controller_manager/src/controller_manager.cpp 69.36% <ø> (+30.34%) ⬆️

... and 30 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, compiles on humble.
After merge we could add a scheduled CI job for ros-controls:master on ROS humble to ros2_control_ci @fmauch?

@fmauch
Copy link
Contributor

fmauch commented Feb 29, 2024

LGTM, compiles on humble. After merge we could add a scheduled CI job for ros-controls:master on ROS humble to ros2_control_ci @fmauch?

Sure we could do that :-)

@bmagyar
Copy link
Member

bmagyar commented Mar 1, 2024

Just one more thing. Could youi please add a distinctive comment about those IFs being there to support source-compatibility with Humble? Same line in both files

@saikishor
Copy link
Member Author

Just one more thing. Could youi please add a distinctive comment about those IFs being there to support source-compatibility with Humble? Same line in both files

Sure, I can do that!

@saikishor
Copy link
Member Author

@bmagyar Done 👍

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants