Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeformat from new pre-commit config #1433

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Codeformat from new pre-commit config #1433

merged 2 commits into from
Mar 11, 2024

Conversation

christophfroehlich
Copy link
Contributor

New pre-commit config introduces clang 18, which likes to reformat some parts of the code.
And it seems that I forgot to run pre-commit on #1429 -> black also complains.

@saikishor
Copy link
Member

This might be needed before #1434 and #1435 right?

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Mar 11, 2024
@christophfroehlich
Copy link
Contributor Author

This might be needed before #1434 and #1435 right?

To have green CI in the backport PRs, yes.

@bmagyar bmagyar merged commit 591b06c into master Mar 11, 2024
7 of 12 checks passed
@bmagyar bmagyar deleted the codeformat branch March 11, 2024 18:27
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
@christophfroehlich @mergify
Codeformat from new pre-commit config (#1433)
c5a5391 
(cherry picked from commit 591b06c)

# Conflicts:
#	rqt_controller_manager/rqt_controller_manager/controller_manager.py
@mergify mergify bot mentioned this pull request Mar 11, 2024
Closed
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
@christophfroehlich @mergify
Codeformat from new pre-commit config (#1433)
48b4648 
(cherry picked from commit 591b06c)

# Conflicts:
#	rqt_controller_manager/rqt_controller_manager/controller_manager.py
@mergify mergify bot mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @saikishor @bmagyar