Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate version.h file per package using the ament_generate_version_header #1449

Merged
merged 3 commits into from
Mar 26, 2024
Merged

generate version.h file per package using the ament_generate_version_header #1449

merged 3 commits into from
Mar 26, 2024

Conversation

saikishor
Copy link
Member

These changes of this PR allow the ros2_control packages to have the version.h generated by the ament_cmake_gen_version_h

fmauch
fmauch reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not mandatory, but AFAIK it is common practice to use ${PROJECT_NAME} when possible.

controller_interface/CMakeLists.txt Outdated Show resolved Hide resolved
controller_manager/CMakeLists.txt Outdated Show resolved Hide resolved
hardware_interface/CMakeLists.txt Outdated Show resolved Hide resolved
joint_limits/CMakeLists.txt Outdated Show resolved Hide resolved
transmission_interface/CMakeLists.txt Outdated Show resolved Hide resolved
@saikishor @fmauch
Use ${PROJECT_NAME} instead of hardcoded naming
954cd5d 
Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
@bmagyar bmagyar merged commit 8d3589e into ros-controls:master Mar 26, 2024
6 of 11 checks passed
@christophfroehlich christophfroehlich mentioned this pull request May 10, 2024
Merged
@saikishor saikishor deleted the add_ament_cmake_gen_version branch August 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch left review comments

@bmagyar bmagyar bmagyar approved these changes

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@mcbed mcbed Awaiting requested review from mcbed

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikishor @fmauch @bmagyar