Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse URDF soft_limits into the HardwareInfo structure #1488

Conversation

adriaroig
Copy link
Contributor

Needs to be merged after #1472

This PR allows to parse the soft_limits into the HardwareInfo structure, so that this can be later reused by the ResourceManager to enforce the limits on the JointCommandInterfaces.

In the test, it is checked that the soft_limits uses the most restrictive value between the soft_limits and the generic limits.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.52%. Comparing base (607755e) to head (7b2865e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.01%     
==========================================
  Files         101      101              
  Lines        8502     8523      +21     
  Branches      759      769      +10     
==========================================
+ Hits         7527     7545      +18     
  Misses        706      706              
- Partials      269      272       +3     
Flag Coverage Δ
unittests 88.52% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hardware_interface/src/component_parser.cpp 92.85% <100.00%> (+0.11%) ⬆️
hardware_interface/test/test_component_parser.cpp 98.71% <80.00%> (-1.29%) ⬇️

@saikishor saikishor force-pushed the parse_soft_limits_from_urdf_to_hw_info branch 4 times, most recently from a9b078d to 583c768 Compare April 23, 2024 17:07
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saikishor saikishor force-pushed the parse_soft_limits_from_urdf_to_hw_info branch from 583c768 to fedd4f3 Compare April 23, 2024 21:43
saikishor added a commit to saikishor/ros2_control that referenced this pull request Apr 23, 2024
@saikishor saikishor force-pushed the parse_soft_limits_from_urdf_to_hw_info branch 2 times, most recently from 1ffd799 to 8445021 Compare April 24, 2024 20:41
@saikishor saikishor force-pushed the parse_soft_limits_from_urdf_to_hw_info branch from 11af33a to 7b2865e Compare May 7, 2024 14:13
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual comment: please update the docs ;) in this case the release notes should be fine, we haven't documented the structure elsewhere.

@saikishor
Copy link
Member

My usual comment: please update the docs ;) in this case the release notes should be fine, we haven't documented the structure elsewhere.

@christophfroehlich Thanks for the review. I've just updated the release notes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmagyar bmagyar merged commit edfb971 into ros-controls:master May 9, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants