-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse URDF soft_limits into the HardwareInfo structure #1488
Parse URDF soft_limits into the HardwareInfo structure #1488
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01%
==========================================
Files 101 101
Lines 8502 8523 +21
Branches 759 769 +10
==========================================
+ Hits 7527 7545 +18
Misses 706 706
- Partials 269 272 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a9b078d
to
583c768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
583c768
to
fedd4f3
Compare
1ffd799
to
8445021
Compare
11af33a
to
7b2865e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual comment: please update the docs ;) in this case the release notes should be fine, we haven't documented the structure elsewhere.
@christophfroehlich Thanks for the review. I've just updated the release notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Needs to be merged after #1472
This PR allows to parse the soft_limits into the HardwareInfo structure, so that this can be later reused by the ResourceManager to enforce the limits on the JointCommandInterfaces.
In the test, it is checked that the soft_limits uses the most restrictive value between the soft_limits and the generic limits.