Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosdoc2 for transmission_interface #1496

Merged
merged 2 commits into from
Apr 29, 2024
Merged

rosdoc2 for transmission_interface #1496

merged 2 commits into from
Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

Similar to #1484: some adaptions for rosdoc2

  • landing page with some text and ros2_control logo
  • a custom doxyfile, so that the images are found

image

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 21, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.67%. Comparing base (16fbde3) to head (ff39d4d).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          96       96           
  Lines       11311    11311           
  Branches     8151     8151           
=======================================
  Hits         7089     7089           
  Misses        715      715           
  Partials     3507     3507
Flag Coverage Δ
unittests 62.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ansmission_interface/differential_transmission.hpp 80.00% <ø> (ø)

saikishor
saikishor approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olivier-stasse
olivier-stasse approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 5d13923 into master Apr 29, 2024
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the rosdoc2_transmission_interface branch April 29, 2024 12:54
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@christophfroehlich @mergify
rosdoc2 for transmission_interface (#1496)
42cfc5e 
* Adaptions for rosdoc2

* Add custom landing page

(cherry picked from commit 5d13923)
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@christophfroehlich @mergify
rosdoc2 for transmission_interface (#1496)
f11e72e 
* Adaptions for rosdoc2

* Add custom landing page

(cherry picked from commit 5d13923)
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
@mergify @christophfroehlich
rosdoc2 for transmission_interface (#1496) (#1509)
614d97d 
* Adaptions for rosdoc2

* Add custom landing page

(cherry picked from commit 5d13923)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
@mergify @christophfroehlich
rosdoc2 for transmission_interface (#1496) (#1510)
1945242 
* Adaptions for rosdoc2

* Add custom landing page

(cherry picked from commit 5d13923)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@moriarty moriarty Awaiting requested review from moriarty

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @olivier-stasse @saikishor