-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware components exception handling in resource manager #1508
Add hardware components exception handling in resource manager #1508
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
- Coverage 88.42% 87.72% -0.71%
==========================================
Files 101 101
Lines 8349 8426 +77
Branches 728 732 +4
==========================================
+ Hits 7383 7392 +9
- Misses 703 767 +64
- Partials 263 267 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Is it possible to test this in any other way then defining a whole bunch of new test classes? I'm thinking about setting up a mocker that throws on every call: |
@bmagyar It's a very nice idea. do you want me to do it in this PR, or can I add it in a separate PR in the upcoming days, in the meantime, we can create an issue from your comment and I can assign it to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR adds the exception handling in the resource manager for the most commonly used hardware component methods that are triggered during their lifecycle transition and communication cycles.
Similar to #1507