Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add joint limiter interface plugins to enforce limits defined in the URDF #1526

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Add joint limiter interface plugins to enforce limits defined in the URDF #1526

wants to merge 65 commits into from

Commits on Sep 28, 2024

  1. make JointTrajectoryPoint as an input through the template argument

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    25bd5ea View commit details
    Browse the repository at this point in the history

  2. check for node parameter interface before declaring and getting the p… 

    …arameters
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    86e0960 View commit details
    Browse the repository at this point in the history

  3. Added methods to check is the parameter and logging interfaces are se… 

    …t or not
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    44f62d2 View commit details
    Browse the repository at this point in the history

  4. add an init method parsing the limits directly in the init method

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    dfd9a34 View commit details
    Browse the repository at this point in the history

  5. update the joint state limiter to use template typename in the header… 

    … file
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0c730aa View commit details
    Browse the repository at this point in the history

  6. check the size of the joint limits and the joint names in the init me… 

    …thod
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    74a9c88 View commit details
    Browse the repository at this point in the history

  7. added joint range limiter library for individual joints control

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    339bca0 View commit details
    Browse the repository at this point in the history

  8. added compute_effort_limits method

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    47b07da View commit details
    Browse the repository at this point in the history

  9. update the velocity limits based on the position of the joint

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    89bd8a8 View commit details
    Browse the repository at this point in the history

  10. fix the limits clamping in the methods

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    cc3b8b5 View commit details
    Browse the repository at this point in the history

  11. Add proper acceleration limits bounding

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    af5f188 View commit details
    Browse the repository at this point in the history

  12. remove the enforce methods of the double vector as it can be handled … 

    …now by types
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f765e76 View commit details
    Browse the repository at this point in the history

  13. Added comments to the has_logging_interface and has_parameter_interfa… 

    …ce methods
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    84d2848 View commit details
    Browse the repository at this point in the history

  14. remove the joint range limiter header and reuse it from the joint sat… 

    …uration limiter + merge them into a single library
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7e0a521 View commit details
    Browse the repository at this point in the history

  15. rename the plugin names to be more consistent with the types the use … 

    …internally
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7c551c3 View commit details
    Browse the repository at this point in the history

  16. Add first version of tests into the joint range limiter

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5dd4e1d View commit details
    Browse the repository at this point in the history

  17. fix the init check bug

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5e8430f View commit details
    Browse the repository at this point in the history

  18. Apply formatting changes

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    84d5cfc View commit details
    Browse the repository at this point in the history

  19. update the joint range limiter test with case of only desired positio… 

    …n availability case
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2f99aaf View commit details
    Browse the repository at this point in the history

  20. Added some minor fixes in the joint range limiter

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f13c9bb View commit details
    Browse the repository at this point in the history

  21. Fill the data of actual or desired fields into the previous commands

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c8d1941 View commit details
    Browse the repository at this point in the history

  22. reset the prev_data_ on initialization

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    fa253af View commit details
    Browse the repository at this point in the history

  23. add test cases of the actual and desired position cases

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5061aa4 View commit details
    Browse the repository at this point in the history

  24. Add tests for the case of no position limits

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7a383e8 View commit details
    Browse the repository at this point in the history

  25. add initial test cases for desired velocity only cases

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9e01dc5 View commit details
    Browse the repository at this point in the history

  26. Enforce wrt to the position limits only when the actual position valu… 

    …e is available
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    dc6c4c3 View commit details
    Browse the repository at this point in the history

  27. change some asserts to expects

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e1cf79d View commit details
    Browse the repository at this point in the history

  28. Use lambdas for better testing

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0aeb2c0 View commit details
    Browse the repository at this point in the history

  29. If the joint is outside the position range, then don't let the joint … 

    …move
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    bb3bf8c View commit details
    Browse the repository at this point in the history

  30. extend tests of acceleration limits also with and without actual posi… 

    …tion value
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    40fe7d9 View commit details
    Browse the repository at this point in the history

  31. Add tests for the case of actuators with actual position state and ac… 

    …celeration limits
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    381a80d View commit details
    Browse the repository at this point in the history

  32. remove unused test cases

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7f19a3b View commit details
    Browse the repository at this point in the history

  33. pass by const reference and parse the optional actual position and ve… 

    …locity
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f16b118 View commit details
    Browse the repository at this point in the history

  34. Added tests for the effort case

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ca590ce View commit details
    Browse the repository at this point in the history

  35. better conditioning for the acceleration limits enforcement

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    baa7928 View commit details
    Browse the repository at this point in the history

  36. Added tests for the desired acceleration case

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ee75a45 View commit details
    Browse the repository at this point in the history

  37. Add tests for the desired jerk test cases

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0600db2 View commit details
    Browse the repository at this point in the history

  38. consider also the acceleration limits when computing the position lim… 

    …iting
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e9f3372 View commit details
    Browse the repository at this point in the history

  39. Fix minor bug in the limit enforcement

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    204e8c4 View commit details
    Browse the repository at this point in the history

  40. better computation of the position limits

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    bddf097 View commit details
    Browse the repository at this point in the history

  41. better combined desired references test

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0307ef8 View commit details
    Browse the repository at this point in the history

  42. Remove LimitsType template from JointLimiterInterface

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    96fa562 View commit details
    Browse the repository at this point in the history

  43. Add SoftJointLimits in JointLimiterInterface

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    94d700c View commit details
    Browse the repository at this point in the history

  44. Move joint limits computation in a separate library

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    82d778a View commit details
    Browse the repository at this point in the history

  45. Implement SoftJointLimiter class

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3beedd3 View commit details
    Browse the repository at this point in the history

  46. Export JointInterfacesSoftLimiter in the joint_limiters.xml

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3ab5d53 View commit details
    Browse the repository at this point in the history

  47. Fix linking problem in test_joint_range_limiter

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5420a6d View commit details
    Browse the repository at this point in the history

  48. Create test_soft_joint_limiter.cpp

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d5c4531 View commit details
    Browse the repository at this point in the history

  49. Fix typo in plugins definition

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b3e6bf2 View commit details
    Browse the repository at this point in the history

  50. Rm soft_joint_limiter.hpp

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    6db838f View commit details
    Browse the repository at this point in the history

  51. Derive SoiftJointLimiter from JointSaturationLimiter<JointControlInte… 

    …rfacesData> and enforce hard limtis
    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f158491 View commit details
    Browse the repository at this point in the history

  52. Test SofJointLimiter in position

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    59952f7 View commit details
    Browse the repository at this point in the history

  53. Solve issues in SoftJointLimiter when prev_command is not defined

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    96c9069 View commit details
    Browse the repository at this point in the history

  54. Test SoftJointLimiter in position and effort

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b0627ec View commit details
    Browse the repository at this point in the history

  55. Test uses cases for SoftJointLimiter in velocity interface

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    609b928 View commit details
    Browse the repository at this point in the history

  56. Format changes

    @adriaroig @saikishor
    adriaroig authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3994b37 View commit details
    Browse the repository at this point in the history

  57. change copyright to PAL

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e51c349 View commit details
    Browse the repository at this point in the history

  58. add pre-comitting fixes

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    725d0c9 View commit details
    Browse the repository at this point in the history

  59. Add intermediate tests to fix the transition bug

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    810e5e7 View commit details
    Browse the repository at this point in the history

  60. Fix the undefined behavior when lower bound is greater than upper bound

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    4c5bc04 View commit details
    Browse the repository at this point in the history

  61. Add some documentation to the helpers

    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    4bc49ef View commit details
    Browse the repository at this point in the history

  62. rename of SoftJointLimiter to JointSoftLimiter and some minor changes 

    from manuel
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e842018 View commit details
    Browse the repository at this point in the history

  63. enable moving out of position limit if velocity is in "right" direction

    @mamueluth @saikishor
    mamueluth authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    55adc1f View commit details
    Browse the repository at this point in the history

  64. warn everytime we reach the limit

    @mamueluth @saikishor
    mamueluth authored and saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b225be4 View commit details
    Browse the repository at this point in the history

  65. update the loguic to check if the actual position is within bounds an… 

    …d it's tolerance
    @saikishor
    saikishor committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    51a69af View commit details
    Browse the repository at this point in the history