Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add jazzy and other minor updates (backport #1521) #1532

Merged
merged 1 commit into from
May 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

  • Add Jazzy workflows (I decided to create dedicated files, because it easier to maintain if we branch for jazzy)
  • Add filters to run the ROS - workflows only if code has changed, and the doc workflow only if docs have changed. (branches+path filter have to match both to run the workflow)
  • Check Docs - workflow now uses the correct branch of control.ros.org (not every page is available on every distro any more).
    This is an automatic backport of pull request [CI] Add jazzy and other minor updates #1521 done by Mergify.

* Add file type filters to workflows

* Add jazzy jobs and update readmes

* Checkout correct branch for docs

* Deactivate jazzy - coverage build

* Specify workflow names

* Update upstream pre-commit wf

* Update coverage build inputs

---------

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
(cherry picked from commit 736d379)

# Conflicts:
#	.github/workflows/rolling-abi-compatibility.yml
@mergify mergify bot added the conflicts label May 8, 2024
Copy link
Contributor Author

mergify bot commented May 8, 2024

Cherry-pick of 736d379 has failed:

On branch mergify/bp/iron/pr-1521
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 736d379.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/README.md
	modified:   .github/workflows/humble-abi-compatibility.yml
	modified:   .github/workflows/humble-binary-build.yml
	new file:   .github/workflows/humble-check-docs.yml
	modified:   .github/workflows/humble-coverage-build.yml
	modified:   .github/workflows/humble-debian-build.yml
	modified:   .github/workflows/humble-pre-commit.yml
	modified:   .github/workflows/humble-rhel-binary-build.yml
	modified:   .github/workflows/humble-semi-binary-build.yml
	modified:   .github/workflows/humble-source-build.yml
	modified:   .github/workflows/iron-abi-compatibility.yml
	modified:   .github/workflows/iron-binary-build.yml
	new file:   .github/workflows/iron-check-docs.yml
	modified:   .github/workflows/iron-coverage-build.yml
	modified:   .github/workflows/iron-debian-build.yml
	modified:   .github/workflows/iron-pre-commit.yml
	modified:   .github/workflows/iron-rhel-binary-build.yml
	modified:   .github/workflows/iron-semi-binary-build.yml
	modified:   .github/workflows/iron-source-build.yml
	new file:   .github/workflows/jazzy-abi-compatibility.yml
	new file:   .github/workflows/jazzy-binary-build.yml
	new file:   .github/workflows/jazzy-check-docs.yml
	new file:   .github/workflows/jazzy-coverage-build.yml
	new file:   .github/workflows/jazzy-debian-build.yml
	new file:   .github/workflows/jazzy-pre-commit.yml
	new file:   .github/workflows/jazzy-rhel-binary-build.yml
	new file:   .github/workflows/jazzy-semi-binary-build.yml
	new file:   .github/workflows/jazzy-source-build.yml
	modified:   .github/workflows/rolling-binary-build.yml
	renamed:    .github/workflows/ci-check-docs.yml -> .github/workflows/rolling-check-docs.yml
	modified:   .github/workflows/rolling-coverage-build.yml
	modified:   .github/workflows/rolling-debian-build.yml
	modified:   .github/workflows/rolling-pre-commit.yml
	modified:   .github/workflows/rolling-rhel-binary-build.yml
	modified:   .github/workflows/rolling-semi-binary-build.yml
	modified:   .github/workflows/rolling-source-build.yml
	modified:   README.md
	new file:   ros2_control-not-released.jazzy.repos
	new file:   ros2_control.jazzy.repos

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/rolling-abi-compatibility.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (f8683a2) to head (4a2254a).

Additional details and impacted files
@@             Coverage Diff             @@
##             iron    #1532       +/-   ##
===========================================
+ Coverage   62.05%   87.45%   +25.40%     
===========================================
  Files         102      101        -1     
  Lines       11570     8077     -3493     
  Branches     8294      714     -7580     
===========================================
- Hits         7180     7064      -116     
+ Misses        740      717       -23     
+ Partials     3650      296     -3354     
Flag Coverage Δ
unittests 87.45% <ø> (+25.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 67 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 745ecba into iron May 8, 2024
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1521 branch May 8, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant