Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test also changes to py files #1548

Merged
merged 1 commit into from
May 23, 2024
Merged

[CI] Test also changes to py files #1548

merged 1 commit into from
May 23, 2024

Conversation

christophfroehlich
Copy link
Contributor

I forgot to add python files to the paths filter of the workflows with #1521, see #1547 for example

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (6ae3950) to head (4b4c2a5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1548   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         102      102           
  Lines        8702     8702           
  Branches      780      780           
=======================================
  Hits         7632     7632           
  Misses        790      790           
  Partials      280      280           
Flag Coverage Δ
unittests 87.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@christophfroehlich christophfroehlich merged commit 9f1007b into master May 23, 2024
18 of 20 checks passed
@christophfroehlich christophfroehlich deleted the tests_python branch May 23, 2024 20:22
mergify bot pushed a commit that referenced this pull request May 23, 2024
mergify bot pushed a commit that referenced this pull request May 23, 2024
christophfroehlich added a commit that referenced this pull request May 23, 2024
(cherry picked from commit 9f1007b)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request May 23, 2024
(cherry picked from commit 9f1007b)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants