-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Test also changes to py files #1548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
May 23, 2024
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
jaron-l,
livanov93,
peterdavidfagan and
VanshGehlot
May 23, 2024 20:03
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1548 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 102 102
Lines 8702 8702
Branches 780 780
=======================================
Hits 7632 7632
Misses 790 790
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. |
fmauch
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
(cherry picked from commit 9f1007b)
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
(cherry picked from commit 9f1007b)
christophfroehlich
added a commit
that referenced
this pull request
May 23, 2024
christophfroehlich
added a commit
that referenced
this pull request
May 23, 2024
saikishor
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add python files to the
paths
filter of the workflows with #1521, see #1547 for example