Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rqt_controller_manager] Add hardware components (backport #1455) #1586

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2024

In addition to #1248 I'd like to add the hardware components to the rqt_controller_manger.

It could also be a different rqt window, but if it is all in one we have the benefit of advertising hardware component lifecycles too.

image

Tooltip
image

It includes #1454 and #1447, but I hope they will get merged earlier.


This is an automatic backport of pull request #1455 done by Mergify.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (b009881) to head (5b49326).
Report is 4 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1586      +/-   ##
==========================================
+ Coverage   62.29%   62.31%   +0.01%     
==========================================
  Files         105      105              
  Lines       11319    11319              
  Branches     7933     7933              
==========================================
+ Hits         7051     7053       +2     
+ Misses        809      807       -2     
  Partials     3459     3459              
Flag Coverage Δ
unittests 62.31% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@bmagyar bmagyar merged commit 4ed2ee0 into humble Oct 11, 2024
11 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1455 branch October 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants