Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rqt_controller_manager] Add hardware components (backport #1455) #1587

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2024

In addition to #1248 I'd like to add the hardware components to the rqt_controller_manger.

It could also be a different rqt window, but if it is all in one we have the benefit of advertising hardware component lifecycles too.

image

Tooltip
image

It includes #1454 and #1447, but I hope they will get merged earlier.


This is an automatic backport of pull request #1455 done by Mergify.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (ae2ed7c) to head (af9beed).
Report is 3 commits behind head on iron.

Additional details and impacted files
@@           Coverage Diff           @@
##             iron    #1587   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         101      101           
  Lines        8078     8078           
  Branches      711      711           
=======================================
  Hits         7065     7065           
  Misses        717      717           
  Partials      296      296           
Flag Coverage Δ
unittests 87.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmagyar bmagyar merged commit b2149f3 into iron Jul 5, 2024
12 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1455 branch July 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants