Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ament linters #1601

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Remove ament linters #1601

merged 1 commit into from
Jul 3, 2024

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Jul 2, 2024

No description provided.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (02b20d2) to head (331ea03).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1601   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files         102      102           
  Lines        8765     8765           
  Branches      787      787           
=======================================
  Hits         7696     7696           
  Misses        791      791           
  Partials      278      278           
Flag Coverage Δ
unittests 87.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We use them in the pre-commit workflows as local dependency, but maybe we can remove them here (there is no test in the python test folder anyways)

@bmagyar bmagyar merged commit 4d60885 into master Jul 3, 2024
17 of 20 checks passed
@bmagyar bmagyar deleted the remove-ament-linters branch July 3, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants