Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the namespaced controller_manager spawner + added tests #1640

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Fix the namespaced controller_manager spawner + added tests #1640

merged 13 commits into from
Jul 29, 2024

Commits on Jul 27, 2024

  1. Fix controllers parameters of controller manager 

    Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
    @delihus @saikishor
    delihus authored and saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    cc75a74 View commit details
    Browse the repository at this point in the history

  2. fix the fallback controllers controller name

    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    19cf6ff View commit details
    Browse the repository at this point in the history

  3. use non prefixed controller name to check if the controller is loaded… 

    … or not
    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    7edce1a View commit details
    Browse the repository at this point in the history

  4. fix the controller manager namespacing in spawner

    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5e1023a View commit details
    Browse the repository at this point in the history

  5. Added test to test with the namespaced controller manager

    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8ccaae1 View commit details
    Browse the repository at this point in the history

  6. remove the --namespace option and prefixed_controller_name internal… 

    … variable
    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    bc03985 View commit details
    Browse the repository at this point in the history

  7. Update the spawner tests with the ros namespacing

    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    78cdceb View commit details
    Browse the repository at this point in the history

  8. Add tests parsing the controllers from the param file to a namespaced… 

    … controller_manager
    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    49498c3 View commit details
    Browse the repository at this point in the history

  9. add --namespace as deprecated and also tests for the deprecated arg

    @saikishor
    saikishor committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    45a4eb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. use spawner namespace for the fallback controllers retrieval as well

    @saikishor
    saikishor committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    abc1e12 View commit details
    Browse the repository at this point in the history

  2. Update the helper scripts documentation and update release notes

    @saikishor
    saikishor committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    caf22b8 View commit details
    Browse the repository at this point in the history

  3. Update the userdoc for the deprecated --namespace option 

    Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
    @saikishor @bmagyar
    saikishor and bmagyar committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    285e547 View commit details
    Browse the repository at this point in the history

  4. DEPRECATED

    @bmagyar
    bmagyar committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    bb81928 View commit details
    Browse the repository at this point in the history