-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Interfaces remapping for controllers #1667
Open
saikishor
wants to merge
20
commits into
ros-controls:master
Choose a base branch
from
saikishor:feat/interface/remapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feature] Interfaces remapping for controllers #1667
saikishor
wants to merge
20
commits into
ros-controls:master
from
saikishor:feat/interface/remapping
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
moriarty,
progtologist and
VX792
August 12, 2024 18:43
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 86.81% 86.97% +0.16%
==========================================
Files 116 117 +1
Lines 10692 10785 +93
Branches 978 997 +19
==========================================
+ Hits 9282 9380 +98
+ Misses 1059 1047 -12
- Partials 351 358 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request is in conflict. Could you fix it @saikishor? |
This pull request is in conflict. Could you fix it @saikishor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a new features to the controllers so that they will be able to remap interfaces, this would be interesting to have as for interfaces such as
effort
the hardware could expose more meaningful interfaces such astorque
,force
orcurrent
and it would get the logic of the controller more complicated if they need to support multiple type of interfaces. Instead the users should be able to remap as simply by defining the remapping definition under the controller's parametersThe controller prints some more explicit log when configuring the controller, so that the user are clear on what interfaces are being remapped
Related to ros-controls/roadmap#61