Preparation of Handles for Variant Support #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bijoua29,
bmagyar,
christophfroehlich,
destogl,
erickisos and
olivier-stasse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
- Coverage 84.59% 84.54% -0.06%
==========================================
Files 115 115
Lines 10537 10467 -70
Branches 972 970 -2
==========================================
- Hits 8914 8849 -65
+ Misses 1295 1293 -2
+ Partials 328 325 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aprotyas
reviewed
Aug 14, 2024
mamueluth
changed the title
bmagyar
previously approved these changes
Aug 15, 2024
saikishor
requested changes
Aug 15, 2024
| } | ||
|
|
||
| protected: | ||
| std::string prefix_name_; | ||
| std::string interface_name_; | ||
| HANDLE_DATATYPE value_; |
There was a problem hiding this comment.
Just to confirm, in this version we define it here but not use it. I believe this is intended
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
bmagyar
approved these changes
Aug 15, 2024
saikishor
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of multiple breaking down #1240 in smaller changes. For an overview explanation and a lot of comments/discussion, please refer to #1240.
This prepares the handle to store the value directly instead of using pointers. The variant is going to be changed to hold different types. The Handles are adapted in this way because the pointer is removed, but the hardware (hw) still needs to be able to set values to the handle and we want to avoid creating and assigning hw loans the handle is now read and write able. The StateInterface is still read only in the sense, that its set_value function is not exposed to controllers via the loan but only to the hw which indeed needs to set values to the StateInterface. A more detailed explanation can be found at #1240 .
NOTE: Everything is fully backward compatible at this point. There is no change visible to Controllers or Hardware. Tests do not need to adapted since we Test through Interface (State-/CommandInteface & Loans which are not changed) Demos can not be adapted to this since in their perspective nothing changed.