-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor spawner to be able to reuse code for ros2controlcli (backport #1661) #1696
Conversation
(cherry picked from commit 0631e3e) # Conflicts: # controller_manager/controller_manager/spawner.py # controller_manager/test/test_spawner_unspawner.cpp
Cherry-pick of 0631e3e has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Fix conflicts * added controller_type parameter setting to the spawner
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## iron #1696 +/- ##
==========================================
- Coverage 62.24% 62.22% -0.02%
==========================================
Files 112 112
Lines 12297 12296 -1
Branches 8598 8602 +4
==========================================
- Hits 7654 7651 -3
+ Misses 879 878 -1
- Partials 3764 3767 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@christophfroehlich has mentioned that ros2 control CLI is missing the functionality to load controllers with the parameter files as we have now with the spawner. upon reviewing the code, the code would need some refactoring to reduce some duplication of code in both places and to be able also to load controllers with namespaced controller manager
This PR would be the first part of refactoring that can go along with #1562, once both the PRs are done, the ros2 control CLI can be modified to add the parameter parsing from the file and proper usage with namespacing.
This is an automatic backport of pull request #1661 done by Mergify.