Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spawner tests timeout on source builds (backport #1692) #1697

Open
wants to merge 3 commits into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

As reported by @christophfroehlich in #1685, it seems that spawner tests are inconsistent and timing out after some time. I was able to reproduce it locally and upon checking it seems like the CM's internal mutexes are blcoking as there is no ControllerManagerRunner in some of these tests. Adding these should fix the above timeout issues. I've tested it locally and it seems to work

Fixes #1685


This is an automatic backport of pull request #1692 done by Mergify.

(cherry picked from commit 079392b)

# Conflicts:
#	controller_manager/test/test_spawner_unspawner.cpp
@mergify mergify bot added the conflicts label Aug 19, 2024
Copy link
Contributor Author

mergify bot commented Aug 19, 2024

Cherry-pick of 079392b has failed:

On branch mergify/bp/humble/pr-1692
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 079392b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_spawner_unspawner.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (9eb64ad) to head (0db5940).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1697      +/-   ##
==========================================
+ Coverage   62.30%   62.31%   +0.01%     
==========================================
  Files         105      105              
  Lines       11314    11318       +4     
  Branches     7925     7929       +4     
==========================================
+ Hits         7049     7053       +4     
  Misses        806      806              
  Partials     3459     3459              
Flag Coverage Δ
unittests 62.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp 59.01% <100.00%> (+0.54%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants