Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Handle other exceptions while loading the controller plugin (backport #1731) #1734

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

As of now, we are only handling the exceptions of the pluginlib::CreateClassException there are many other exceptions defined by the pluginlib, that might be also interesting to catch. I'm using std::exception as the main PluginlibException is derived from std::runtime_error and which is derived from std::exception, and this gives us way to be generic (https://github.com/ros/pluginlib/blob/jazzy/pluginlib/include/pluginlib/exceptions.hpp#L43)


This is an automatic backport of pull request #1731 done by Mergify.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.13%. Comparing base (19d81e6) to head (39b1cea).
Report is 2 commits behind head on iron.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1734      +/-   ##
==========================================
- Coverage   62.17%   62.13%   -0.04%     
==========================================
  Files         109      109              
  Lines       12218    12221       +3     
  Branches     8549     8547       -2     
==========================================
- Hits         7596     7594       -2     
- Misses        874      879       +5     
  Partials     3748     3748              
Flag Coverage Δ
unittests 62.13% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 69.69% <0.00%> (-0.36%) ⬇️

@bmagyar bmagyar merged commit 8534e6d into iron Oct 10, 2024
10 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1731 branch October 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants