Log exception type when catching the exception #1749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some tests, it seems like there is no proper description of the exception message and it is clearer through the type of exception.
For instance, the issue we faced is:
InvalidParameterValueException
(https://github.com/ros2/rclcpp/blob/2f71d6e249f626772da3f8a1bb7c8d141d9d0d52/rclcpp/src/rclcpp/parameter_map.cpp#L147) and the error message is "No parameter value set" and it was not clear to use until we went to the source code and started looking, so to handle such situations, I think it is better also to log the type of the exceptions that are thrown.Thank you!