Add test coverage for params_file parameter in spawner/unspawner tests

[SantoshGovindaraj]

Overview

• Solve Add tests to the params_file parameter in test_spawner_unspawner.cpp #1702
• This PR adds test cases for the params_file parameter in the test_spawner_unspawner.cpp.

[christophfroehlich]

Thanks for your contribution. Please run pre-commit locally to satisfy the linters.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (eb4c19d) to head (094c1c2).
Report is 25 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   86.77%   86.76%   -0.02%     
==========================================
  Files         116      116              
  Lines       10703    10716      +13     
  Branches      981      981              
==========================================
+ Hits         9288     9298      +10     
- Misses       1062     1064       +2     
- Partials      353      354       +1     

Flag	Coverage Δ
unittests	86.76% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp	99.19% <100.00%> (+0.04%)	⬆️

... and 1 file with indirect coverage changes

[saikishor]

Perfect. This should do the proper check.

As @christophfroehlich pointed out, please fix the pre-commit and push it

[SantoshGovindaraj]

Thanks @saikishor and @christophfroehlich

I have fixed the changes as mentioned.

[saikishor]

Thanks @saikishor and @christophfroehlich

I have fixed the changes as mentioned.

I'm waiting for @christophfroehlich or other maintainers to trigger the CI

[christophfroehlich]

Thanks. I haven't checked if the assertion was added to every test, but it seems to be fine.

[saikishor]

LGTM

[SantoshGovindaraj]

Thanks @saikishor and @christophfroehlich for prompt replies.
Please feel free to let me know if any further changes required, I can amend the changes.