Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] add thread_priority option to the ros2_control_node #1820

Merged

Conversation

saikishor
Copy link
Member

Right now, the thread_priority is hard-coded to 50, this PR allows the users to be able to choose their desired priority by setting a parameter at launch time

int const kSchedPriority = 50;

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.62%. Comparing base (b0da4a1) to head (6a6a837).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
+ Coverage   87.60%   87.62%   +0.02%     
==========================================
  Files         120      120              
  Lines       12223    12223              
  Branches     1093     1093              
==========================================
+ Hits        10708    10711       +3     
+ Misses       1125     1123       -2     
+ Partials      390      389       -1     
Flag Coverage Δ
unittests 87.62% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 88.57% <66.66%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I realized that we don't mention the ros2_control_node not even once in the docs. Should we?

@saikishor
Copy link
Member Author

LGTM.
I realized that we don't mention the ros2_control_node not even once in the docs. Should we?

I think it's a good idea. It gives some idea on how to instantiate their control stack.

@saikishor saikishor changed the title add thread_priority option to the ros2_control_node [ros2_control_node] add thread_priority option to the ros2_control_node Oct 30, 2024
@bmagyar bmagyar added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Oct 30, 2024
@bmagyar bmagyar merged commit 832602d into ros-controls:master Oct 30, 2024
22 checks passed
@saikishor saikishor deleted the add/thread_priority/cm_option branch October 30, 2024 20:24
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 832602d)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
#	doc/release_notes.rst
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 832602d)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
#	doc/release_notes.rst
christophfroehlich pushed a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
christophfroehlich pushed a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor added a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants