Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hardware spawner and add tests for it (backport #1759) #1828

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Fix Hardware spawner and add tests for it (backport #1759) #1828

merged 4 commits into from
Nov 10, 2024

Commits on Nov 9, 2024

  1. Fix Hardware spawner and add tests for it (#1759) 

    * Tests for hardware spawner.

* Fully support spawning a list of hardware components

* Use python3 coverage instead of ros2 run in tests

* Actually check component's state after changing it

* Update hardware_spawner's user documentation

---------

Co-authored-by: Dr. Denis Štogl <denis@stoglrobotics.de>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit 5dbd6d5)

# Conflicts:
#	controller_manager/CMakeLists.txt
    @fmauch @christophfroehlich
    fmauch authored and christophfroehlich committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b1c45eb View commit details
    Browse the repository at this point in the history

  2. Fix conflict

    @bmagyar @christophfroehlich
    bmagyar authored and christophfroehlich committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    255da48 View commit details
    Browse the repository at this point in the history

  3. Fix the missing bcolors.ENDC in hardware_spawner log prints (#1870)

    @saikishor @christophfroehlich
    saikishor authored and christophfroehlich committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    282dfdd View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Choose pass_urdf_as_parameter as false

    @saikishor
    saikishor authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    db456b9 View commit details
    Browse the repository at this point in the history