-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gmock CMP0115 #1830
Merged
Merged
Fix gmock CMP0115 #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
fmauch,
peterdavidfagan,
saikishor,
VanshGehlot and
VX792
October 31, 2024 19:20
saikishor
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1830 +/- ##
=======================================
Coverage 88.25% 88.25%
=======================================
Files 121 121
Lines 12301 12301
Branches 1093 1093
=======================================
Hits 10856 10856
Misses 1051 1051
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmagyar
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Nov 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 434f7f5) # Conflicts: # controller_manager/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 434f7f5) # Conflicts: # controller_manager/CMakeLists.txt
This was referenced Nov 10, 2024
christophfroehlich
added a commit
that referenced
this pull request
Nov 10, 2024
bmagyar
pushed a commit
that referenced
this pull request
Nov 10, 2024
saikishor
pushed a commit
to pal-robotics-forks/ros2_control
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes