Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Add the realtime_tools lock_memory method to prevent page faults (backport #1822) #1851

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Add lock_memory to avoid page faults and lock the memory at the beginning to physical RAM


This is an automatic backport of pull request #1822 done by Mergify.

…ent page faults (#1822)

(cherry picked from commit e6e69c1)

# Conflicts:
#	doc/release_notes.rst
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

Cherry-pick of e6e69c1 has failed:

On branch mergify/bp/iron/pr-1822
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit e6e69c1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/src/ros2_control_node.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/release_notes.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.34%. Comparing base (13aed56) to head (fd9103d).
Report is 1 commits behind head on iron.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1851      +/-   ##
==========================================
- Coverage   62.35%   62.34%   -0.01%     
==========================================
  Files         112      112              
  Lines       13098    13102       +4     
  Branches     8883     8886       +3     
==========================================
+ Hits         8167     8169       +2     
+ Misses        949      946       -3     
- Partials     3982     3987       +5     
Flag Coverage Δ
unittests 62.34% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 76.92% <50.00%> (-3.08%) ⬇️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit a52f800 into iron Nov 5, 2024
8 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1822 branch November 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants