Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from thread_priority.hpp to realtime_helpers.hpp (backport #1829) #1867

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

Change from the deprecated thread_priority.hpp to new realtime_helpers.hpp


This is an automatic backport of pull request #1829 done by Mergify.

(cherry picked from commit 8fa60db)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
@mergify mergify bot added the conflicts label Nov 8, 2024
Copy link
Contributor Author

mergify bot commented Nov 8, 2024

Cherry-pick of 8fa60db has failed:

On branch mergify/bp/iron/pr-1829
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 8fa60db.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/ros2_control_node.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (e4d1450) to head (b1d42cb).
Report is 1 commits behind head on iron.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1867      +/-   ##
==========================================
+ Coverage   62.28%   62.31%   +0.02%     
==========================================
  Files         112      112              
  Lines       13137    13137              
  Branches     8911     8912       +1     
==========================================
+ Hits         8183     8186       +3     
- Misses        962      963       +1     
+ Partials     3992     3988       -4     
Flag Coverage Δ
unittests 62.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 68.88% <ø> (ø)

... and 3 files with indirect coverage changes

@bmagyar bmagyar merged commit 9ce8ab3 into iron Nov 8, 2024
7 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1829 branch November 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants