Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CM] Use robot_description topic instead of parameter and don't crash on empty URDF 🦿 #940

Merged
merged 13 commits into from
Jun 7, 2023
Merged

[CM] Use robot_description topic instead of parameter and don't crash on empty URDF 🦿 #940

merged 13 commits into from
Jun 7, 2023

Commits on Apr 25, 2023

  1. allow an empty robot description file. 

    * Deprecate passing of robot description file to controller manager
* subscribe to robot_state_publisher to get robot_description_file
    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    0e05f2e View commit details
    Browse the repository at this point in the history

  2. on startup wait for robot description, however allow to reveice later

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    dbfeab0 View commit details
    Browse the repository at this point in the history

  3. undo waiting for robot description file, change QoS instead

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    fc2cbb5 View commit details
    Browse the repository at this point in the history

  4. apply suggestions from review

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a08c386 View commit details
    Browse the repository at this point in the history

  5. check if resource manager has been initialized

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    22a114e View commit details
    Browse the repository at this point in the history

  6. rename flag, add some ttests in resource manager

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    997c305 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @destogl @mamueluth
    destogl authored and mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a0ac528 View commit details
    Browse the repository at this point in the history

  8. update test fixture to use publishing, some tests are failing

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f27f0f9 View commit details
    Browse the repository at this point in the history

  9. Not working! tried waiting for urdf to arrive before starting control… 

    …lers in test

In tests we have to be sure, that our urdf arrived before continuing
with the actuell tests otherwise they will naturally fail...
    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c338a94 View commit details
    Browse the repository at this point in the history

  10. workaround for topic issues while testing

    @mamueluth
    mamueluth committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ecc2218 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge branch 'master' into allow_empty_urdf

    @bmagyar
    bmagyar authored May 30, 2023
    Configuration menu
    Copy the full SHA
    d160f21 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'master' into allow_empty_urdf

    @destogl
    destogl authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e064f0d View commit details
    Browse the repository at this point in the history

  2. Cleanup some tiny issues with the code.

    @destogl
    destogl committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b66d186 View commit details
    Browse the repository at this point in the history