Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruckig-based joint limiter that limits jerk. #970

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

destogl
Copy link
Member

@destogl destogl commented Mar 16, 2023

This PR required #971 to be merged first.

This PR adds new dependecy to Ruckig, therefore the package is not added into ros2_control meta package and should be installed as needed.

destogl and others added 4 commits March 7, 2023 18:42
- Added initial structures for joint-limit plugins.
- Correct ruckig name and make tests to work.
- Rename the joint_limits package
- Comment and author cleanup
- Base class does not require libary.
- Delete extra layer of abstraction since not all plugins require a vector of smoothing objects.
- Restore simple_joint_limiter to a working state
- Implement init() and enforce()
- Return of joint_limits package.
- Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working.
Debug and optimize Rucking JointLimiter.
…r) (#6)

* Merge error handling possilibity on read and write.

* Ros2 control extensions rolling joint limits plugins (#5)

* Added initial structures for joint-limit plugins.

* Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working.

Co-authored-by: AndyZe <zelenak@picknik.ai>

* Add option to automatically update parameters after getting them from parameter server.

* Modify simple joint limiting plugin (same as changes to moveit2 filter)

* Add backward_ros dependency for crash stack trace

* Check for required inputs in simple joint limiter

* Change services history QOS to 'keep all' so client req are not dropped

* Add missing on 'pluginlib' dependency explicitly.

* Update ControllerParameters structure to support custom prefix and use in filters.

* Update messge.

* Change controller param changed msg log level to info instead of error

---------

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Co-authored-by: AndyZe <zelenak@picknik.ai>
Co-authored-by: bijoua <bijou.abraham@technipfmc.com>
Co-authored-by: bijoua29 <73511637+bijoua29@users.noreply.github.com>
@destogl destogl self-assigned this Mar 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

This pull request is in conflict. Could you fix it @destogl?

@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2023

This pull request is in conflict. Could you fix it @destogl?

Copy link
Contributor

mergify bot commented Jan 29, 2024

This pull request is in conflict. Could you fix it @destogl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants