Update all demos using the description from topic rather than the parameter #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that.
saikishor
requested changes
Mar 2, 2024
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
|
Migrated all demos and manually tested them. |
github-actions
bot
requested review from
bmagyar,
christophfroehlich,
destogl,
erickisos,
moriarty,
progtologist and
VanshGehlot
saikishor
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
The changes look good to me!
Let's merge once ros-controls/ros2_control#1358 is merged!
I don't see any specific reason to wait for that, as this PR removes long-deprecated mechanisms and is in line with the docs again, but sure, it's not necessarily required before ros-controls/ros2_control#1358 is merged. |
|
Sure, we can merge it. You have a point 👍🏽 Let's wait for one more approval for merging it :) |
christophfroehlich
approved these changes
Mar 3, 2024
|
No, this will not work on humble because we subscribe to robot_description and not ~/robot_description on rolling. |
ah you are right. should we backport the rest? |
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) (#472) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) (#472) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 11d699b)
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) (#472) (#473) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 11d699b) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure things work after ros-controls/ros2_control#1358 is merged.
I'll update this demo by demo whenever I find the time and check the demos according to their docs after modifying them.