Adding break-system-packages pip option for noble in devel_task #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
|
I can't see from the commit log why we started installing setuptools from pip. This seems to me like something we'd done for a specific reason that has been lost to time. Is it worth switching this to use the system provided setuptools for noble and phase out this pip override? |
colcon requires setuptools 30.3.0[1] and we had previously needed to install it from pypi to get that version on older Ubuntu distros, but since Ubuntu Focal had python3-setuptools 45.2.0 and Debian Buster has 40.8.0 so we've not needed this for most of the last few years. [1]: https://github.com/colcon/colcon-core/blob/master/setup.cfg#L41
nuclearsandwich
pushed a commit
that referenced
this pull request
Mar 16, 2024
* Remove pip-installed setuptools. colcon requires setuptools 30.3.0[1] and we had previously needed to install it from pypi to get that version on older Ubuntu distros, but since Ubuntu Focal had python3-setuptools 45.2.0 and Debian Buster has 40.8.0 so we've not needed this for most of the last few years. [1]: https://github.com/colcon/colcon-core/blob/master/setup.cfg#L41 --------- Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com> Co-authored-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rpr jobs are failing due to the
externally-managed-environmentpip error, i.e.:https://build.ros2.org/job/Rpr__rosbag2__ubuntu_noble_amd64/4/console
This PR adds a conditional to use
--break-system-packageswhen installingsetuptoolswithpip3.Maybe not affecting Rpr jobs but I was wondering if some other templates installing pip packages should also be updated, thoughts?