Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the ROS 1 -> 2 CMake instructions #4767

Merged
merged 17 commits into from
Sep 30, 2024
Merged

Polish the ROS 1 -> 2 CMake instructions #4767

merged 17 commits into from
Sep 30, 2024

Commits on Sep 22, 2024

  1. Polish the ROS 1 -> 2 CMake instructions 

    WIP. Progress so far:

* Use section headings to CMakeLists.txt steps appear in the TOC
* Use modern CMake targets instead of standard CMake variables
* Use Active voice and second person perspective
* Include links to real examples

Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    8db4dc2 View commit details
    Browse the repository at this point in the history

  2. Consistent headings 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    02148be View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Updates down to Testing section 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c9b10bb View commit details
    Browse the repository at this point in the history

  2. Active voice in Linters section 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8f68e76 View commit details
    Browse the repository at this point in the history

  3. Proofreading 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c2f5d9e View commit details
    Browse the repository at this point in the history

  4. remove none 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f08324d View commit details
    Browse the repository at this point in the history

  5. Misc updates to lower section 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fefc16f View commit details
    Browse the repository at this point in the history

  6. Build system first, assume already using package format 2 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1e4abef View commit details
    Browse the repository at this point in the history

  7. Update instructions, removing unnecessary stuff 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ed52172 View commit details
    Browse the repository at this point in the history

  8. Some updates to code changes section 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    30582c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Undo non-CMake changes to save for another PR 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    50e863b View commit details
    Browse the repository at this point in the history

  2. Only change CMake code this time 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c31a35e View commit details
    Browse the repository at this point in the history

  3. more changes 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    81944b0 View commit details
    Browse the repository at this point in the history

  4. Misc fixes 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2f4c020 View commit details
    Browse the repository at this point in the history

  5. Misc fixes after running through example 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    521ed5d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Clearly link ROS 2 style guide 

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz @clalancette
    sloretz and clalancette authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    92246d4 View commit details
    Browse the repository at this point in the history

  2. Add member_of_group tag code block 

    Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
    @sloretz
    sloretz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    53dc7e6 View commit details
    Browse the repository at this point in the history